Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix failing test on arm64 machines #718

Merged
merged 1 commit into from
Jan 10, 2024
Merged

chore: fix failing test on arm64 machines #718

merged 1 commit into from
Jan 10, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jan 10, 2024 •
edited
Loading

This test is failing locally on an M3 mac. Likely would fail on a linux arm64 as well.

==================== Test output for //lib/tests/run_binary_expansions:expansions_golden_test:
1,2c1,2
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions/expansions_out
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions
---
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions/expansions_out
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions
5,6c5,6
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions/src_1
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions/src_1
---
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions/src_1
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions/src_1
9,10c9,10
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions/src_1
< bazel-out/PLATFORM_arm64-opt/bin/lib/tests/run_binary_expansions/src_1
---
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions/src_1
> bazel-out/PLATFORM-opt/bin/lib/tests/run_binary_expansions/src_1
12,14c12,14
< bazel-out/PLATFORM_arm64-opt/bin
< bazel-out/PLATFORM_arm64-opt/bin
< PLATFORM_arm64
---
> bazel-out/PLATFORM-opt/bin
> bazel-out/PLATFORM-opt/bin
> PLATFORM
FAIL: files "lib/tests/run_binary_expansions/expansions_out" and "lib/tests/run_binary_expansions/expansions_golden" differ. 
================================================================================

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Covered by existing test cases

@gregmagolan gregmagolan changed the title refactor: remove --enable-runfiles from javascript recommended bazelrc settings (#715) chore: fix failing test on arm64 machines Jan 10, 2024
@gregmagolan gregmagolan merged commit 57bcf28 into main Jan 10, 2024
71 checks passed
@gregmagolan gregmagolan deleted the fixup_test_on_arm64 branch January 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

@kormide kormide Awaiting requested review from kormide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard